Skip to content

Conversation

clarfonthey
Copy link
Contributor

These were left in to make migration a bit easier, although they should be removed now since they were never stable.

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 18, 2025
@rust-log-analyzer

This comment has been minimized.

@jhpratt
Copy link
Member

jhpratt commented Jul 18, 2025

r=me with passing CI

@rust-log-analyzer

This comment has been minimized.

@clarfonthey clarfonthey force-pushed the maybe-uninit-deprecated branch from 274ef37 to ddea06f Compare July 18, 2025 15:52
@clarfonthey
Copy link
Contributor Author

All green now.

@clarfonthey clarfonthey force-pushed the maybe-uninit-deprecated branch 2 times, most recently from 8ef56a0 to 3176d11 Compare July 19, 2025 21:14
@clarfonthey
Copy link
Contributor Author

Resolved the issue, but currently CI is failing due to #144183, so, that's a blocker for merging. Won't bother marking this PR as blocked though since it's currently blocking all PRs.

@jhpratt
Copy link
Member

jhpratt commented Jul 19, 2025

Sounds good. Merge at your own discretion once upstream is figured out.

@clarfonthey clarfonthey force-pushed the maybe-uninit-deprecated branch from 3176d11 to 5628885 Compare July 20, 2025 02:33
@clarfonthey
Copy link
Contributor Author

Appears to be passing now, although I don't think I can merge myself.

@jhpratt
Copy link
Member

jhpratt commented Jul 20, 2025

Ah, I thought you were a reviewer; I'd have explicitly delegated otherwise. No worries.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 20, 2025

📌 Commit 5628885 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 20, 2025
…d, r=jhpratt

Remove deprecated `MaybeUninit` slice methods

These were left in to make migration a bit easier, although they should be removed now since they were never stable.
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jul 20, 2025
…d, r=jhpratt

Remove deprecated `MaybeUninit` slice methods

These were left in to make migration a bit easier, although they should be removed now since they were never stable.
bors added a commit that referenced this pull request Jul 20, 2025
Rollup of 12 pull requests

Successful merges:

 - #141260 (Allow volatile access to non-Rust memory, including address 0)
 - #143604 (Stabilize `const_float_round_methods`)
 - #143833 (Ban projecting into SIMD types [MCP838])
 - #143988 ([rustdoc] Make aliases search support partial matching)
 - #144078 (Fix debuginfo-lto-alloc.rs test)
 - #144111 (Remove deprecated `MaybeUninit` slice methods)
 - #144116 (Fixes for LLVM 21)
 - #144134 (Cleanup unicode table gen)
 - #144142 (Add implicit sized bound to trait ascription types)
 - #144148 (Remove pretty print hack for async blocks)
 - #144169 (interpret: fix TypeId pointers being considered data pointers)
 - #144196 (Initialize mingw for the runner's user)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 20, 2025
Rollup of 11 pull requests

Successful merges:

 - #141260 (Allow volatile access to non-Rust memory, including address 0)
 - #143604 (Stabilize `const_float_round_methods`)
 - #143988 ([rustdoc] Make aliases search support partial matching)
 - #144078 (Fix debuginfo-lto-alloc.rs test)
 - #144111 (Remove deprecated `MaybeUninit` slice methods)
 - #144116 (Fixes for LLVM 21)
 - #144134 (Cleanup unicode table gen)
 - #144142 (Add implicit sized bound to trait ascription types)
 - #144148 (Remove pretty print hack for async blocks)
 - #144169 (interpret: fix TypeId pointers being considered data pointers)
 - #144196 (Initialize mingw for the runner's user)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5e5ac49 into rust-lang:master Jul 20, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 20, 2025
rust-timer added a commit that referenced this pull request Jul 20, 2025
Rollup merge of #144111 - clarfonthey:maybe-uninit-deprecated, r=jhpratt

Remove deprecated `MaybeUninit` slice methods

These were left in to make migration a bit easier, although they should be removed now since they were never stable.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 21, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#141260 (Allow volatile access to non-Rust memory, including address 0)
 - rust-lang/rust#143604 (Stabilize `const_float_round_methods`)
 - rust-lang/rust#143988 ([rustdoc] Make aliases search support partial matching)
 - rust-lang/rust#144078 (Fix debuginfo-lto-alloc.rs test)
 - rust-lang/rust#144111 (Remove deprecated `MaybeUninit` slice methods)
 - rust-lang/rust#144116 (Fixes for LLVM 21)
 - rust-lang/rust#144134 (Cleanup unicode table gen)
 - rust-lang/rust#144142 (Add implicit sized bound to trait ascription types)
 - rust-lang/rust#144148 (Remove pretty print hack for async blocks)
 - rust-lang/rust#144169 (interpret: fix TypeId pointers being considered data pointers)
 - rust-lang/rust#144196 (Initialize mingw for the runner's user)

r? `@ghost`
`@rustbot` modify labels: rollup
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
…d, r=jhpratt

Remove deprecated `MaybeUninit` slice methods

These were left in to make migration a bit easier, although they should be removed now since they were never stable.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#141260 (Allow volatile access to non-Rust memory, including address 0)
 - rust-lang#143604 (Stabilize `const_float_round_methods`)
 - rust-lang#143988 ([rustdoc] Make aliases search support partial matching)
 - rust-lang#144078 (Fix debuginfo-lto-alloc.rs test)
 - rust-lang#144111 (Remove deprecated `MaybeUninit` slice methods)
 - rust-lang#144116 (Fixes for LLVM 21)
 - rust-lang#144134 (Cleanup unicode table gen)
 - rust-lang#144142 (Add implicit sized bound to trait ascription types)
 - rust-lang#144148 (Remove pretty print hack for async blocks)
 - rust-lang#144169 (interpret: fix TypeId pointers being considered data pointers)
 - rust-lang#144196 (Initialize mingw for the runner's user)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 29, 2025
…d, r=jhpratt

Remove deprecated `MaybeUninit` slice methods

These were left in to make migration a bit easier, although they should be removed now since they were never stable.
@clarfonthey clarfonthey deleted the maybe-uninit-deprecated branch September 13, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants